-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change enqueue! dequeue! to push! popfirst! #743
Conversation
Looks like CI is failing So can't use |
For some reason I forgot to copy this change from the last PR.
Should be fixed |
And now it should. Sorry, I'm working directly in Github so I can't spot mistakes before you run CI for me. I always leave stupid mistakes like this but I eventually manage to remove all of them. |
Since we're here: PriorityQueue is the last DS using the dequeue! enqueue! API. I can take care of it (in another PR) if you want. That way all the queues will use the same API (unless I missed another). There's still the Stack discussion (#677 and #296) that initially spurred my original PR that should be resolved at some point (before 1.0 I guess). |
Yesss all checks passed. Finally ready to merge. |
thanks! |
Attempt number two. I think I covered everything.